mirror/Vencord
1
0
Fork 0
mirror of https://github.com/Vendicated/Vencord.git synced 2025-02-23 23:15:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

address feedback

Browse source
This commit is contained in:
Vendicated 2025-02-17 01:41:45 +01:00
parent 434fd8ae52
commit 9e820214c5
No known key found for this signature in database
GPG key ID: D66986BAF75ECF18
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/webpack/webpack.ts
View file

@ -112,13 +112,14 @@ export function _initWebpack(webpackRequire: WebpackRequire) {
// Credits to Zerebos for implementing this in BD, thus giving the idea for us to implement it too // Credits to Zerebos for implementing this in BD, thus giving the idea for us to implement it too
const TypedArray = Object.getPrototypeOf(Int8Array); const TypedArray = Object.getPrototypeOf(Int8Array);
function _shouldIgnoreValue(value: any) { function shouldIgnoreValue(value: any) {
if (value == null) return true; if (value == null) return true;
if (value === window) return true; if (value === window) return true;
if (value === document || value === document.documentElement) return true; if (value === document || value === document.documentElement) return true;
if (value[Symbol.toStringTag] === "DOMTokenList" || value[Symbol.toStringTag] === "IntlMessagesProxy") return true; if (value[Symbol.toStringTag] === "DOMTokenList" || value[Symbol.toStringTag] === "IntlMessagesProxy") return true;
// Discord might export a Proxy that returns non-null values for any property key (e.g. their i18n Proxy (caught by above check)) // Discord might export a Proxy that returns non-null values for any property key which would pass all findByProps filters.
// We can use a unique string to detect this and ignore it // One example of this is their i18n Proxy. However, that is already covered by the IntlMessagesProxy check above.
// As a fallback if they ever change the name or add a new Proxy, use a unique string to detect such proxies and ignore them
if (value["is this a proxy that returns values for any key?"]) return true; if (value["is this a proxy that returns values for any key?"]) return true;
if (value instanceof TypedArray) return true; if (value instanceof TypedArray) return true;
@ -136,7 +137,7 @@ function makePropertyNonEnumerable(target: Object, key: PropertyKey) {
} }
export function _blacklistBadModules(requireCache: NonNullable<AnyWebpackRequire["c"]>, exports: ModuleExports, moduleId: PropertyKey) { export function _blacklistBadModules(requireCache: NonNullable<AnyWebpackRequire["c"]>, exports: ModuleExports, moduleId: PropertyKey) {
if (_shouldIgnoreValue(exports)) { if (shouldIgnoreValue(exports)) {
makePropertyNonEnumerable(requireCache, moduleId); makePropertyNonEnumerable(requireCache, moduleId);
return true; return true;
} }
@ -145,13 +146,16 @@ export function _blacklistBadModules(requireCache: NonNullable<AnyWebpackRequire
return false; return false;
} }
let hasOnlyBadProperties = true;
for (const exportKey in exports) { for (const exportKey in exports) {
if (_shouldIgnoreValue(exports[exportKey])) { if (shouldIgnoreValue(exports[exportKey])) {
makePropertyNonEnumerable(exports, exportKey); makePropertyNonEnumerable(exports, exportKey);
} else {
hasOnlyBadProperties = false;
} }
} }
return false; return hasOnlyBadProperties;
} }
let devToolsOpen = false; let devToolsOpen = false;